Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for React 16 and 17 #8340

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Conversation

alex-page
Copy link
Member

@alex-page alex-page commented Feb 14, 2023

WHY are these changes introduced?

Fixes #8331

WHAT is this pull request doing?

Removing support for v16 and v17 from Shopify Polaris.

@alex-page alex-page changed the base branch from main to v11-major February 14, 2023 09:12
@alex-page alex-page self-assigned this Feb 14, 2023
@alex-page alex-page marked this pull request as ready for review February 15, 2023 00:32
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2023

size-limit report 📦

Path Size
polaris-react-cjs 216.05 KB (0%)
polaris-react-esm 138.94 KB (0%)
polaris-react-esnext 194.07 KB (0%)
polaris-react-css 41.88 KB (0%)

Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We doing changesets for the v11 major changes or shall they be curated afterwards?

@alex-page
Copy link
Member Author

alex-page commented Feb 15, 2023

@BPScott I was being a bit lazy. I will add a changelog now instead of before releasing v11.

@alex-page alex-page merged commit 79f40cd into v11-major Feb 15, 2023
@alex-page alex-page deleted the rm-legacy-react-support branch February 15, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants