Add minitest hooks and make seeding fast #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KComrade53
reviewed
Mar 21, 2024
Comment on lines
+11
to
+17
| has_and_belongs_to_many :properties, | ||
| join_table: :categories_properties, | ||
| foreign_key: :category_id, | ||
| association_foreign_key: :property_friendly_id | ||
| def property_friendly_ids=(ids) | ||
| self.properties = Property.where(friendly_id: ids) | ||
| end |
There was a problem hiding this comment.
I don't think this relationship is set up correctly. When I tried running it on your branch, the attributes array is empty for all the categories in categories.json
There was a problem hiding this comment.
I imagine the other relationships will have similar issue, that's just the one I checked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More robust testing, but more importantly changes seeding from ~50s to ~2s