ForbidTStruct handles nilable properties #180
Conversation
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
| sig { returns(Integer) } | ||
| attr_accessor :baz | ||
|
|
||
| sig { params(baz: Integer, foo: T.nilable(Integer), bar: T.nilable(String)).void } |
There was a problem hiding this comment.
I'm not clear why we need to change the argument order here if only dealing with keyword arguments?
There was a problem hiding this comment.
Order is kept for keyword arguments foo and bar. Only baz is moved earlier.
There was a problem hiding this comment.
This is a rule within Sorbet, required keyword parameters must be before the optional ones: https://sorbet.run/#%23%20typed%3A%20true%0Aextend%20T%3A%3ASig%0A%0Asig%20%7Bparams%28x%3A%20Integer%2C%20y%3A%20Integer%29.void%7D%0Adef%20foo%28x%3A%2042%2C%20y%3A%29%0A%20%20puts%28x%20%2B%201%29%0Aend
| sig { returns(Integer) } | ||
| attr_accessor :baz | ||
|
|
||
| sig { params(baz: Integer, foo: T.nilable(Integer), bar: T.nilable(String)).void } |
There was a problem hiding this comment.
Order is kept for keyword arguments foo and bar. Only baz is moved earlier.
andyw8
changed the title
|
I fixed the typo in the PR title in case anyone is searching for this. |
Closes #179.