Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test controller implementation #1554

Closed
vinistock opened this issue Mar 28, 2023 · 0 comments · Fixed by Shopify/vscode-ruby-lsp#562
Closed

Add test controller implementation #1554

vinistock opened this issue Mar 28, 2023 · 0 comments · Fixed by Shopify/vscode-ruby-lsp#562
Assignees
Labels
enhancement New feature or request transferred This issue was transferred from vscode-ruby-lsp
Milestone

Comments

@vinistock
Copy link
Member

vinistock commented Mar 28, 2023

VS Code's offers a super nice test interface that we should include in the Ruby LSP.

We already know which tests exist in a file by executing the code lens request, so we can add a client middleware to capture all code lenses that have type: "test" and use those to populate the test controller.

This PR has an initial exploration of how to implement the test controller Shopify/vscode-ruby-lsp#382.

The test interface should

  • Allow users to run test through it
  • Be updated when someone runs the test using the code lens instead of the test interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request transferred This issue was transferred from vscode-ruby-lsp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants