Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Pull Requests extension causes unwanted textDocument/didOpen events #2649

Closed
andyw8 opened this issue Oct 2, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@andyw8
Copy link
Contributor

andyw8 commented Oct 2, 2024

I noticed that textDocument/didOpen events were being fired for files that I didn't have open in the editor. By disabled extensions one-by-one, I found that the cause was the GitHub Pull Requests extension.

This is a problem because:

  • Processing those other files has a performance impact
  • If the file opened in the background is large, it may trigger the "This file is too long" error.

Further investigation is needed to understand why this happening.

@andyw8 andyw8 added the bug Something isn't working label Oct 2, 2024
@vinistock
Copy link
Member

Is there anything we can do on our side though? Maybe we can report the issue to the extension and ask if it's intended behaviour.

@andyw8
Copy link
Contributor Author

andyw8 commented Oct 22, 2024

Seems solved by #2693

@andyw8 andyw8 closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants