Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off IRB integration on server launch #2010

Merged
merged 1 commit into from
May 3, 2024

Conversation

vinistock
Copy link
Member

Motivation

The previous approach of trying to avoid STDOUT prints from IRB doesn't work properly because it ends up swallowing the communication between the debugger and the editor - making it impossible to attach.

Implementation

I started turning off the IRB integration (which is the thing printing to STDOUT) when we launch the server in debug mode instead.

@vinistock vinistock added bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes labels May 3, 2024
@vinistock vinistock self-assigned this May 3, 2024
@vinistock vinistock requested a review from a team as a code owner May 3, 2024 19:30
@vinistock vinistock requested review from andyw8 and st0012 May 3, 2024 19:30
@vinistock vinistock merged commit 324c642 into main May 3, 2024
41 checks passed
@vinistock vinistock deleted the vs/turn_off_irb_integration branch May 3, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants