-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prism requirement to v0.28 #2017
Conversation
2fa5a9b
to
1618f36
Compare
0316673
to
54add89
Compare
Are the |
The upgrade ended up uncovering some other Windows errors and I was trying to get CI to pass. If you prefer, I can split that into a separate PR, but the changes are necessary. |
Ok, yeah I'd say we should split them since there's quite a lot of changes. I'll limit my review to the Ruby part. |
Split the other part, which needs to be merged first #2033. |
#2033 is blocked on Windows, so I'll update this branch to remove the |
@@ -86,6 +86,8 @@ jobs: | |||
# We need some Ruby installed for the environment activation tests | |||
- name: Set up Ruby | |||
uses: ruby/setup-ruby@v1 | |||
with: | |||
bundler-cache: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Motivation
Update our Prism requirement to
v0.28
or higher. Versionv0.28
includes the newASCIISource
with performance optimization for sources that do not contain multibyte characters, which fixes the performance regression we introduced in semantic highlighting.Implementation
Before, each part of a constant path was also a constant read. After this version, only the parent parts of the constant path may be constant reads, the main name of the constant is embedded inside the constant path node.
Automated Tests
Fixed a few tests.