Remove notes related to neovim 0.9 and cleanup docs #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithinbekal
changed the title
nithinbekal
added
the
other
andyw8
reviewed
May 17, 2024
| @@ -63,96 +63,45 @@ mason_lspconfig.setup_handlers { | |||
|
|
|||
| ### Neovim Limitations | |||
|
|
|||
| Ruby LSP only supports pull diagnostics, and neovim versions prior to v0.10.0-dev-695+g58f948614 only support [publishDiagnostics](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_publishDiagnostics). | |||
There was a problem hiding this comment.
Let's also add a note under the ## Neovim header, e.g.:
Ensure you using v0.10 or newer.
andyw8
reviewed
May 17, 2024
EDITORS.md
Outdated
| @@ -63,96 +63,45 @@ mason_lspconfig.setup_handlers { | |||
|
|
|||
| ### Neovim Limitations | |||
There was a problem hiding this comment.
Let's rename this to 'Additional Setup (Optional)'?
|
@andyw8 Addressed both comments. |
nithinbekal
added
the
server
andyw8
reviewed
May 17, 2024
EDITORS.md
Outdated
| Ruby LSP only supports pull diagnostics, and neovim versions prior to v0.10.0-dev-695+g58f948614 only support [publishDiagnostics](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_publishDiagnostics). | ||
| Additional setup is required to enable diagnostics from Ruby LSP to appear in neovim. | ||
| `rubyLsp/workspace/dependencies` is a custom method currently supported only in the VS Code plugin. | ||
| The following snipped adds `ShowRubyDeps` command to show dependencies in the quickfix list. |
There was a problem hiding this comment.
Suggested change
| The following snipped adds `ShowRubyDeps` command to show dependencies in the quickfix list. | |
| The following snippet adds `ShowRubyDeps` command to show dependencies in the quickfix list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neovim 0.10 has been released with support for
publishDiagnosticsso there is no need to suggest manually adding support for it.The snippet also contained code for adding
ShowRubyDepscommand, so I added a description for that instead. I also cleaned up the formatting of the code snippet in a separate commit.