Fully initialize global state in tests by calling apply_options #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in this comment: #1926 (comment) A global state is not fully initialized without `apply_options` being called, which the current `with_server` test helper does not do. This means that when tests are being run, detections around things like test library are not performed, which can yield unexpected results to developers, especially addon authors. This commit changes the `with_server` test helper to call `apply_options`.
st0012
added
bugfix
andyw8
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in this comment: #1926 (comment) A global state is not fully initialized without
apply_optionsbeing called, which the currentwith_servertest helper does not do.This means that when tests are being run, detections around things like test library are not performed, which can yield unexpected results to developers, especially addon authors.
This commit changes the
with_servertest helper to callapply_options.