Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Shopify/rubygems.org#56 for details
This PR requests a custom url from RubyGems.org when asking for OTP. If email/password is given (in the signin case), it'll use basic auth, otherwise it'll use api key auth.
Potential blockers / changes
I have to pass down email/password down multiple levels (
rubygems_api_request
,ask_otp
,webauthn_verification_url
). Probably need to structure that better if this solution is chosen.