-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide BeginNode/EndNode and use a finer-grained coloring scheme for effect nodes #59
Conversation
I added svg graphs to compare before/after. |
* Split "effect" into memory, call, alloc, sync. * Use a softer color for memory.
Leave them in unless they're very simple. |
Not convinced about this purple but I'll merge it for now. |
Feel free to tweak. I think I'll take anything except red for memory accesses, because red is already used for control flow and control flow is completely unrelated to memory accesses. |
Both are usually fixed, that's why. |
Fixes #45.
examples/ruby/example_instance_of.bgv:5
:Before:
After:
examples/ruby/example_while_break.bgv:5
:Before:
After:
examples/graalvm-ce-java11-21.2.0/fib-ruby.bgv.gz:3
:Before:
After:
"Empty if":
Before:
After: