-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force-enable host-based circuits #243
Merged
michaelkipper
merged 5 commits into
mkipper/global-circuit-breaker
from
mkipper/global-circuit-breaker-simple-integer
Jul 4, 2019
Merged
Force-enable host-based circuits #243
michaelkipper
merged 5 commits into
mkipper/global-circuit-breaker
from
mkipper/global-circuit-breaker-simple-integer
Jul 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a83daf
to
c2721ba
Compare
thegedge
reviewed
Jul 2, 2019
7a73849
to
926074d
Compare
thegedge
approved these changes
Jul 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the most sane way to roll this out on a per-host basis 👍
csfrancis
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much nicer than the C implementation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR allows
SEMIAN_CIRCUIT_BREAKER_FORCE_HOST
to force-enable host-based circuits.Why
To deploy #227 on core, we want to enable host-based circuits on a single node, so we can observe their behaviour through a Rails console.
cc: @Shopify/servcomm