Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oauth begin method #16

Merged
merged 1 commit into from
May 17, 2021
Merged

Add oauth begin method #16

merged 1 commit into from
May 17, 2021

Conversation

Paulinakhew
Copy link
Contributor

No description provided.

paulomarg
paulomarg reviewed May 11, 2021
View reviewed changes
Copy link
Collaborator

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! Looking at this, I wonder if the DbSessionStorage class belongs in the Models folder - I'd consider moving it to a lib folder since it's not necessarily a model (even though it uses one).

README.md Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
routes/web.php Outdated Show resolved Hide resolved
tests/Feature/DBSessionStorageTest.php Outdated Show resolved Hide resolved
@Paulinakhew Paulinakhew marked this pull request as ready for review May 14, 2021 13:55
@Paulinakhew Paulinakhew requested a review from a team as a code owner May 14, 2021 13:55
paulomarg
paulomarg reviewed May 14, 2021
View reviewed changes
resources/views/top_level.blade.php Outdated Show resolved Hide resolved
app/Lib/DbSessionStorage.php Outdated Show resolved Hide resolved
database/migrations/2021_05_11_151158_add_online_access_info_to_sessions.php Outdated Show resolved Hide resolved
routes/web.php Show resolved Hide resolved
MuhammadFarag
MuhammadFarag approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@MuhammadFarag MuhammadFarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@paulomarg paulomarg merged commit 00eee5d into main May 17, 2021
@paulomarg paulomarg deleted the add-oauth-begin branch May 17, 2021 19:39
@cjohansson cjohansson mentioned this pull request Aug 22, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

@MuhammadFarag MuhammadFarag MuhammadFarag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Paulinakhew @MuhammadFarag @paulomarg