Add session checking middleware #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
add_session_check_middleware
branch
from
a8aa846
to
45ef62f
Compare
paulomarg
force-pushed
the
add_session_check_middleware
branch
from
45ef62f
to
5fe080a
Compare
MuhammadFarag
approved these changes
May 18, 2021
| @@ -111,7 +111,7 @@ function(Shopify\Auth\OAuthCookie $cookie) { | |||
| Route::post('/graphql', function (Request $request) { | |||
| $result = Utils::graphqlProxy($request->header(), $request->cookie(), $request->getContent()); | |||
| return response($result->getDecodedBody())->withHeaders($result->getHeaders()); | |||
| }); | |||
| })->middleware('shopify.auth:online'); | |||
There was a problem hiding this comment.
It is weird that we need to explicitly add the middlewear here even though we have added it to kernel. I don't think it should be necessary 🤔 . Maybe we have misconfigured something
There was a problem hiding this comment.
I actually did that on purpose - you can set up a middleware to run for a group of endpoints, but we don't want to authenticate every request, only those that are fired from the client side using authenticatedFetch, so I added it individually to the endpoints that actually need it. Devs can definitely create a separate route group and apply the middleware to it, but I felt like keeping all the endpoints in a single file makes it easier to understand.
paulomarg
force-pushed
the
add_session_check_middleware
branch
from
e53aad2
to
daf0b52
Compare
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Most app requests will need to be authenticated when they interact with Shopify. In order to make it easy to ensure that a certain action is fully cleared to access the API, we should provide a middleware to run all of the checks.
WHAT is this pull request doing?
Adding a middleware that can be used as
shopify.auth[:online/:offline](defaulting to online), which will load the session from the current request (auth header / cookies) and check if it:If the session is not valid, the middleware will:
X-Shopify-API-Request-Failure-ReauthorizeandX-Shopify-API-Request-Failure-Reauthorize-Url) indicating that the app should go to login.The default client in the React app was also updated to wrap around the
authenticatedFetchcall with a function that looks for those headers in the response, and breaks out of the Admin to go to/login.Checklist