Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding example REST route #22

Merged
merged 1 commit into from
May 18, 2021

Conversation

paulomarg
Copy link
Collaborator

@paulomarg paulomarg commented May 18, 2021

WHY are these changes introduced?

Our app is currently showcasing how to make GraphQL requests using the proxy, but not using the clients we provide. To demonstrate the scenario, we could add an endpoint to our API that shows how requests can be made.

WHAT is this pull request doing?

Adding a very simple REST example, which just fetches a few products and returns those, to display how one might be able to do that.

While adding a test for that, I noticed we didn't have a test for the GraphQL proxy in non-embedded apps, so I just added it here since the data provider works exactly the same as the new test.

Checklist

  • I have added/updated tests for this change

@paulomarg paulomarg requested a review from a team as a code owner May 18, 2021 15:09
@paulomarg paulomarg marked this pull request as draft May 18, 2021 15:14
@paulomarg paulomarg marked this pull request as ready for review May 18, 2021 15:26
Copy link
Contributor

@MuhammadFarag MuhammadFarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Great work

@paulomarg paulomarg merged commit e53aad2 into add_session_check_middleware May 18, 2021
@paulomarg paulomarg deleted the add_example_rest_route branch May 18, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants