Client router #29
Merged
Client router #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
approved these changes
May 20, 2021
Comment on lines
6
to
7
| const {router} = props; | ||
| return <AppBridgeClientRouter history={router} />; |
There was a problem hiding this comment.
props.router doesn't exist here, we want to be getting the history from the props.
Suggested change
| const {router} = props; | |
| return <AppBridgeClientRouter history={router} />; | |
| const {history} = props; | |
| return <AppBridgeClientRouter history={history} />; |
paulomarg
approved these changes
May 20, 2021
resources/js/react/App.jsx
Outdated
Comment on lines
63
to
65
| <Route path="/"> | ||
| <ProductsPage/> | ||
| </Route> |
There was a problem hiding this comment.
Sorry, forgot I had one more comment. I think we can make this slightly simpler too:
Suggested change
| <Route path="/"> | |
| <ProductsPage/> | |
| </Route> | |
| <Route path="/" component={ProductsPage}/> |
MuhammadFarag
force-pushed
the
client-router
branch
from
1ef7793
to
7eb12f4
Compare
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
Checklist