Slim down default Laravel app #3
Conversation
MuhammadFarag
commented
Apr 30, 2021
•
MuhammadFarag
commented
- Remove User model and migrations
- Remove the default view
| @@ -6,16 +6,5 @@ | |||
|
|
|||
There was a problem hiding this comment.
Not visible here, but we may not want to extend from Illuminate\Auth\Middleware\Authenticate as I'm sure it will involve other authentication means. We may even want to get fully rid of this class, what do you think?
There was a problem hiding this comment.
I removed it from the middleware, so it shouldn't be called. I kept it as a place holder. I can delete it though 👍
There was a problem hiding this comment.
Cool, as long as it doesn't run it probably doesn't matter if it's there!
| Route::prefix('api') | ||
| ->middleware('api') | ||
| ->namespace($this->namespace) | ||
| ->group(base_path('routes/api.php')); | ||
|
|
There was a problem hiding this comment.
I'm not sure we want to remove the api routes - we'll need API endpoints to fetch data once we go through OAuth.
There was a problem hiding this comment.
I believe the reason api is a separate thing here because it has its own security rules etc. I thought we delete it and we add it when we need it.
Now, thinking about it. Laravel users will probably expect that it will be there 🤔
There was a problem hiding this comment.
That's true, but Laravel is usually extremely configurable since it has dependency injection for just about anything (and that usually involves a config object 😄 ), so we can probably turn off any features we don't want.
|
I think we may need a rebase on this PR so we can move ahead :) |
Remove User model and migrations Remove the default view
MuhammadFarag
force-pushed
the
remove-unused-components
branch
from
b46991f
to
f0fb84c
Compare
