Session storage #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulinakhew
reviewed
May 3, 2021
.env.testing
Outdated
| SHOPIFY_API_KEY=test-api-key | ||
| SHOPIFY_API_SECRET_KEY=test-secret-key | ||
| SCOPES=read_products,write_products | ||
| HOST_NAME=www.app-host-name.com |
There was a problem hiding this comment.
Should we change this to something like www.testshop.myshopify.com?
There was a problem hiding this comment.
Also this should probably not have a www. prefix as we generally do not use it across our libraries or documentation
There was a problem hiding this comment.
I believe this is the app host-name not the shop host-name 🤔
There was a problem hiding this comment.
ohhh I see! Maybe we can even do something like
HOST_NAME=12345asdf.ngrok.io
tanema
approved these changes
May 3, 2021
.env.testing
Outdated
| SHOPIFY_API_KEY=test-api-key | ||
| SHOPIFY_API_SECRET_KEY=test-secret-key | ||
| SCOPES=read_products,write_products | ||
| HOST_NAME=www.app-host-name.com |
There was a problem hiding this comment.
Also this should probably not have a www. prefix as we generally do not use it across our libraries or documentation
|
Thank you for the review @tanema |
MuhammadFarag
force-pushed
the
session-storage
branch
from
08b70a6
to
95abf78
Compare
Paulinakhew
approved these changes
May 3, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Create a database-based
SessionStorageclass and use that to set upContext.WHAT is this pull request doing?
.env.testSessionmodel with database migratoinsDbSessionStoragewrapper aroundSessionmodelContext