Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Timber and some more... :) #18

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

humancopy
Copy link
Contributor

Hey,

This commit updates to the latest Timber but also changes some extra stuff:

  1. Separate the grid specific mixins to _grid_mixins.scss.liquid to make it reusable
  2. Move .clearfix definition to _rest-of-styles.scss.liquid and use the clearfix mixin
  3. Upgrade some dependencies

Thanks ;)

@cshold
Copy link
Contributor

cshold commented Oct 2, 2015

This repo is more of an example of how structure your files, not rely on it for the most up to date Timber version. I'll add that to the readme.

Can you revise the PR to revert the Timber changes and just update the dependencies?

@humancopy
Copy link
Contributor Author

I understand, but still don't you think it's better to keep this example updated so if someone wants to use it they get the latest Timber?

@cshold
Copy link
Contributor

cshold commented Oct 2, 2015

That means updating source code in multiple places, which definitely isn't ideal. This repo is all about the build tasks, so I'd rather keep the focus on that.

@humancopy
Copy link
Contributor Author

How about making this project the source for Timber? Or even better, merging this with Timber (as a src folder) and having the build task there?

@cshold
Copy link
Contributor

cshold commented Oct 5, 2015

That's not on the roadmap right now, but definitely a thought we've had.

@humancopy
Copy link
Contributor Author

So how about continue updating this one with Timber until it does? I don't mind being responsible on making the necessary adjustments every once in a while :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants