-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest Timber and some more... :) #18
base: master
Are you sure you want to change the base?
Conversation
…-styles.scss.liquid
This repo is more of an example of how structure your files, not rely on it for the most up to date Timber version. I'll add that to the readme. Can you revise the PR to revert the Timber changes and just update the dependencies? |
I understand, but still don't you think it's better to keep this example updated so if someone wants to use it they get the latest Timber? |
That means updating source code in multiple places, which definitely isn't ideal. This repo is all about the build tasks, so I'd rather keep the focus on that. |
How about making this project the source for Timber? Or even better, merging this with Timber (as a src folder) and having the build task there? |
That's not on the roadmap right now, but definitely a thought we've had. |
So how about continue updating this one with Timber until it does? I don't mind being responsible on making the necessary adjustments every once in a while :) |
Hey,
This commit updates to the latest Timber but also changes some extra stuff:
_grid_mixins.scss.liquid
to make it reusable.clearfix
definition to_rest-of-styles.scss.liquid
and use the clearfix mixinThanks ;)