Use simple lambdas #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonMWhite
reviewed
Mar 13, 2017
shopify_python/google_styleguide.py
Outdated
| @@ -63,6 +63,10 @@ class GoogleStyleGuideChecker(checkers.BaseChecker): | |||
| 'finally-too-long', | |||
| "The larger the 'finally' body size, the more likely that an exception will be raised during " | |||
| "resource cleanup activities."), | |||
| 'C2611': ('Lambda has %(found)i nodes', | |||
JasonMWhite
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambdas can be very useful but they are "[h]arder to read and debug than local functions. The lack of names means stack traces are more difficult to understand. Expressiveness is limited because the function may only contain an expression."
To limit need to debug lambdas let's encourage them to be simple and to have a maximum number os AST nodes. The default of 15 was chosen arbitrarily.