Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kredis compiler #1336

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Add Kredis compiler #1336

merged 1 commit into from
Jan 11, 2023

Conversation

bdewater
Copy link
Contributor

@bdewater bdewater commented Dec 28, 2022 •
edited
Loading

Motivation

Needed type check guarantees for the dynamically created attribute methods and enum methods from Kredis.

Implementation

Used an extension similar to the existing one for FrozenRecord.

Tests

Added tests.

@bdewater bdewater requested a review from a team as a code owner December 28, 2022 16:09
@bdewater bdewater force-pushed the kredis-compiler branch 3 times, most recently from d5c90cf to cce80a1 Compare January 4, 2023 16:00
@bdewater-thatch bdewater-thatch mentioned this pull request Jan 9, 2023
Merged
3 tasks
@bdewater bdewater force-pushed the kredis-compiler branch 2 times, most recently from ef47e7f to eaa8d00 Compare January 10, 2023 17:20
KaanOzkan
KaanOzkan approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@KaanOzkan KaanOzkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler LGTM However, this is my first time looking at kredis.

spec/tapioca/dsl/compilers/kredis_spec.rb Show resolved Hide resolved
egiurleo
egiurleo approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@egiurleo egiurleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing readable code and thorough tests!

@KaanOzkan KaanOzkan merged commit 7eaa3fa into Shopify:main Jan 11, 2023
@bdewater bdewater deleted the kredis-compiler branch January 12, 2023 03:34
@shopify-shipit shopify-shipit bot temporarily deployed to production February 21, 2023 12:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan approved these changes

@egiurleo egiurleo egiurleo approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdewater @egiurleo @KaanOzkan @paracycle