Fix typing for the getter of serialized columns #1423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
According to this table, serialized columns always return an empty Array or Hash if their coders are either an Array or Hash respectively and the value in the database is
null
.Currently tapioca assumes the getter will always return a nilable type, which is not true:
Toggle me for an example!
Implementation
This PR changes the getters return type for serialized columns where the coder is one of those exceptional classes.
Tests
Added tests for all getters, making sure the Array and Hash ones check for a not nilable type being returned.