dsl --verify error should suggest database reset
#1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
changed the title
dsl --verify error should suggest database reset
Morriar
approved these changes
Mar 13, 2023
andyw8
reviewed
Mar 13, 2023
lib/tapioca/commands/dsl.rb
Outdated
| @@ -343,6 +343,8 @@ def report_diff_and_exit_if_out_of_date(diff, command) | |||
| #{set_color("RBI files are out-of-date. In your development environment, please run:", :green)} | |||
| #{set_color("`#{default_command(command)}`", :green, :bold)} | |||
| #{set_color("Once it is complete, be sure to commit and push any changes", :green)} | |||
| If you don't observe any changes after running the command locally, ensure your database is in a good | |||
| state eg. run `bin/rails db:reset` | |||
There was a problem hiding this comment.
Suggested change
| state eg. run `bin/rails db:reset` | |
| state e.g. run `bin/rails db:reset` |
KaanOzkan
force-pushed
the
ko/dsl-verify-suggestion
branch
from
a24430c
to
5dff6bc
Compare
KaanOzkan
force-pushed
the
ko/dsl-verify-suggestion
branch
from
5dff6bc
to
0f0c0c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This came up in some issue reports. It's a tough one to debug but an easy suggestion to make.
Implementation
Tests
Existing tests updated.