Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if OID is defined before referencing #1461

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

KaanOzkan
Copy link
Contributor

@KaanOzkan KaanOzkan commented Mar 30, 2023

Motivation

Resolves #1437

I was under the assumption if ActiveRecord::ConnectionAdapters::PostgreSQL is defined OID would be loaded too but that doesn't have to be the case if the connection adapter is loaded manually

Implementation

Now we check for the exact class we're referencing instead.

Tests

Tested locally in a demo application 👍

@KaanOzkan KaanOzkan requested a review from a team as a code owner March 30, 2023 21:25
@KaanOzkan KaanOzkan merged commit 06dc15e into main Mar 30, 2023
@KaanOzkan KaanOzkan deleted the ko/check-oid-definition branch March 30, 2023 22:44
@shopify-shipit shopify-shipit bot temporarily deployed to production March 31, 2023 15:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uninitialized constant ActiveRecord::ConnectionAdapters::PostgreSQL::OID (NameError)
2 participants