Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing for SecurePassword authenticate* methods #1824

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Improve typing for SecurePassword authenticate* methods #1824

merged 1 commit into from
Mar 17, 2024

Conversation

bdewater
Copy link
Contributor

@bdewater bdewater requested a review from a team as a code owner March 15, 2024 15:31
@bdewater
Copy link
Contributor Author

Getting a bunch of unrelated NoMethodError: undefined method build' for an instance of Google::Protobuf::DescriptorPool`

@andyw8
Copy link
Contributor

andyw8 commented Mar 15, 2024

Yep, it's under investigation: #1819

@bdewater bdewater force-pushed the secure-password-authenticate branch from fb60e07 to 4c0c7c2 Compare March 16, 2024 15:20
@bdewater bdewater force-pushed the secure-password-authenticate branch from 4c0c7c2 to d1018da Compare March 16, 2024 15:21
@paracycle paracycle added the enhancement New feature or request label Mar 17, 2024
paracycle
paracycle approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paracycle paracycle merged commit 8d8a5af into Shopify:main Mar 17, 2024
13 of 19 checks passed
@bdewater bdewater deleted the secure-password-authenticate branch March 17, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan KaanOzkan is a code owner automatically assigned from Shopify/sorbet

@vinistock vinistock Awaiting requested review from vinistock vinistock is a code owner automatically assigned from Shopify/sorbet

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdewater @andyw8 @paracycle