load default compilers before user defined compilers #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to have someone review this PR? I believe the tests are failing for unrelated reasons. |
|
@stathis-alexander There is a CI failure |
…d-order-of-compilers
|
@KaanOzkan Hello, I believe that was an unrelated issue to do with protobuf. I merged master where I believe the issue to be addressed, but I cannot seem to figure out how to kick off the build again. |
KaanOzkan
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the tapioca default compilers load after the user defined compilers. This makes it impossible to extend or monkey patch a default compiler without monkey patching the load order in an initializer. See here for a comment concerning this behavior.
This PR switches the load order of default compilers to go before the user defined compilers. This allows users to extend the default compilers or monkey patch custom behavior with compilers of their own.