Fix default gem RBI generation #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a gem is a default gem, that does not mean that the `spec` is a `Gem::Specification`. It is still a `Bundler::RemoteSpecification` which delegates the `files` method to a gem spec.
vinistock
approved these changes
Oct 26, 2021
Morriar
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes in #541 broke default gem RBI generation.
Implementation
Mostly reverting back to the old code, with an explicit
T.unsafeinstead of a shim.Tests
Added a test with
did_you_meangem to test RBI generation for default gems. I validated that the test fails without the revert and passes after the revert.