This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Skip font preload warning #716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent suggesting the usage of preload_tag for third party assets. Fixes Shopify#693.
eloyesp
force-pushed
the
skip_preload_font
branch
from
b110e71
to
74b9c6c
Compare
|
👋🏻 Hi @eloyesp! Thanks for your contribution. Unfortunately the Ruby version of theme check is no longer receiving dev support and is in the process of being deprecated. The issue that you are solving has been transferred to the theme-tools repository. If you would still like to contribute, please make a change over there. Sorry about this and thank you again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Shopify/theme-tools#411 by skipping font preload tags.
Also related to: Shopify/dawn#1932 .