Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync Liquid Docs Schema #799

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

shopify-dev-bot[bot]
Copy link
Contributor

🤖 This Pull Request was created automatically 🤖

Reviewing this PR

This Pull Request should be reviewed daily. Once you've confirmed that all changes make sense, rebase and merge this PR

@shopify-dev-bot shopify-dev-bot bot requested a review from a team as a code owner October 1, 2024 18:00
@charlespwd
Copy link
Contributor

This is a big diff and is sus as hell.

@lukeh-shopify
Copy link
Contributor

@mllemango It looks like you merged this in the upstream repo. The diffs look identical to the one being mirrored here. Are you able to share some context for this change?

@charlespwd
Copy link
Contributor

charlespwd commented Oct 2, 2024

Looking at this more closely it seems like it's OK. size, upcase and so on are all filters but somehow they were showing up in the objects.json's article object properties.

image

I don't think that's supposed to be there.

Copy link
Contributor

@charlespwd charlespwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah OK this makes sense. All clear!

Weird that the article object somehow inherited those filters as properties.

@charlespwd charlespwd merged commit c4d4397 into main Oct 2, 2024
5 checks passed
@graygilmore graygilmore deleted the bot/liquid-docs-schema/2024-10-01--18-00-00 branch October 2, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants