This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
Add custom selectors option. Fix theme-product-form logic #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The goal of this PR is to add an optional parameter to pass custom selectors to theme-product-form. Currenly, it is always default to fixed selector. This would open allow fix apps issues that happen during same selectors in form. For example, ReCharge that currently broke this lib.
This problems also mentioned in issues:
#135
#146
Also id change logic was changed. Many apps depens on id field during initializing as also many of them depens on change event of this field. Logic was rebuild to always change id field, so apps logic will not be corrupt.
Approach