Fix historyState bug with tg-remote #97
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96
If you were to call
Turbolinks.loadPage
directly (bypassingTurbolinks.visit
),rememberReferer
would not be called.tg-remote
does exactly this viaPage.refresh
and supplying anxhr
inpage.coffee
.This PR duplicates a call to
rememberReferer
, but should have no effect in theTurbolinks.visit
case since it's just performing the same thing twice. It's feels a little unfortunate that it had to be duplicatedI think that this is a proper fix because:
tg-remote
that didn't result in a redirect would haveB
as the referer, and re-pushC
onto the stack to result in A > B > C > CI've tested it out on my own project with the back & forward buttons in these scenarios:
xhr
but noonlyKeys
)refresh-on-success
(xhr
+onlyKeys
)Also good for testing is the example app (added a new button + test for this kind of behaviour)
Don't merge: still need to fix:
cc @Shopify/tnt