Update CustomerSegmentTemplate prop names
#1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrescilliaA
force-pushed
the
pa/cleanup-customer-segmentat-template-prop-names
branch
from
804f231
to
e8105c5
Compare
lauramann
reviewed
Aug 22, 2023
lauramann
reviewed
Aug 22, 2023
| @@ -11,17 +11,23 @@ export interface CustomerSegmentTemplateProps { | |||
| title: string; | |||
| /* Localized description(s) of the template. */ | |||
| description: string | string[]; | |||
| /* Code snippet to render in the template with syntax highlighting. */ | |||
| /* DEPRECATED - Code snippet to render in the template with syntax highlighting. */ | |||
There was a problem hiding this comment.
Do you know how long we should keep the deprecated props before removing them?
There was a problem hiding this comment.
Just until the changes are made in the segmentation templates app and the admin. Since no other parties are using our APIs we don't need to respect the deprecation cycle.
There was a problem hiding this comment.
I just wanted it to be clear while we make the transition :)
PrescilliaA
force-pushed
the
pa/cleanup-customer-segmentat-template-prop-names
branch
from
e8105c5
to
e198e10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We are cleaning up the
CustomerSegmentTemplateprop names to make them more stream lined before we expose the API to partners.Solution
Renaming the following props:
templateQuery->querytemplateQueryInsert->queryInsertdateAdded->createdOnMarking the previous as deprecated until we add support for the new props in web and in our 1P application: segmentation-templates-app.
Checklist