-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CustomerSegmentTemplate
prop names
#1274
Update CustomerSegmentTemplate
prop names
#1274
Conversation
804f231
to
e8105c5
Compare
@@ -11,17 +11,23 @@ export interface CustomerSegmentTemplateProps { | |||
title: string; | |||
/* Localized description(s) of the template. */ | |||
description: string | string[]; | |||
/* Code snippet to render in the template with syntax highlighting. */ | |||
/* DEPRECATED - Code snippet to render in the template with syntax highlighting. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know how long we should keep the deprecated props before removing them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just until the changes are made in the segmentation templates app and the admin. Since no other parties are using our APIs we don't need to respect the deprecation cycle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted it to be clear while we make the transition :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
e8105c5
to
e198e10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Background
We are cleaning up the
CustomerSegmentTemplate
prop names to make them more stream lined before we expose the API to partners.Solution
Renaming the following props:
templateQuery
->query
templateQueryInsert
->queryInsert
dateAdded
->createdOn
Marking the previous as deprecated until we add support for the new props in web and in our 1P application: segmentation-templates-app.
Checklist