Remove location api #1569
Merged
Remove location api #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
oluwatimio
requested review from
robin-drexler,
brianshen1990,
anahita-m and
gracerivas
robin-drexler
approved these changes
Nov 28, 2023
| location: StatefulRemoteSubscribable<{ | ||
| pathname: string; | ||
| search: string; | ||
| }>; |
There was a problem hiding this comment.
also here? we should be able to remove the omit
There was a problem hiding this comment.
Hmm yes, Id also have to update shopify.dev 😬 alongside this since that references the types
There was a problem hiding this comment.
Should be OK, we are using Docs_FullPageApi instead of FullPageApi if I remember correctly
There was a problem hiding this comment.
Actually no wouldnt need to do that since we omit location
brianshen1990
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Fixes https://github.com/Shopify/core-issues/issues/62603
Solution
Checklist