Validation settings Admin UI Extension target #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
2 tasks
jamesvidler
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Looks good to me. Don't forget to add a changeset (minor change), otherwise nothing will get published to the unstable package.
Has anyone from the Admin team reviewed this PR? @MitchLillie might be able to help with that.
There was a problem hiding this comment.
Just a general question, why is this in a launch-options.ts file separate form validation-settings.ts, when it appears to be specific to the validation api?
There was a problem hiding this comment.
There are a number of different checkout rules coming soon, order submission may fall into this general class of admin ui extensions, for example. Validation settings is one of this class of target. Happy to do single target/single directory here.
aledalgrande
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Resolves https://github.com/Shopify/checkout-web/issues/18126
spec'ed here https://github.com/Shopify/ui-api-design/pull/197
tl;dr: a task-specific extension target that configures only validation functions.
Checklist