-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new extension targets for action extensions everywhere #1837
Conversation
77c46b9
to
65ec5fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
>; | ||
|
||
/** | ||
* Renders an admin action in the order fulfilled card. Open this extension from the "3-dot" menu inside the order fulfilled card. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themarkappleby What's this pattern called? Card overflow menu?
449a8b3
to
4248d2b
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, but we should add a changeset before merging
9c2ca2b
to
947b443
Compare
Hi! I have tried to deploy a variant admin extension, but despite updating the package, Shopify CLI still returns this error: Error while updating drafts: Invalid extension point(s) configured: admin.variant-details.action.render Is this target already supposed to work? |
Hi @bakura10 - Apologies, our docs were incorrect. The correct target name is |
Thanks, I can confirm this works :) |
closes https://github.com/Shopify/app-ui/issues/835
https://shopify-dev.ui-extensions-026v.josh-white.us.spin.dev/docs/api/admin-extensions/unstable/api/extension-targets
Adding type definitions for the new extension targets being added.
Targets being added:
Checklist