add new extension targets for action extensions everywhere #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaWhite1
force-pushed
the
jw-new-targets
branch
from
77c46b9
to
65ec5fe
Compare
AaronSpringut
approved these changes
Mar 22, 2024
| >; | ||
|
|
||
| /** | ||
| * Renders an admin action in the order fulfilled card. Open this extension from the "3-dot" menu inside the order fulfilled card. |
There was a problem hiding this comment.
@themarkappleby What's this pattern called? Card overflow menu?
JoshuaWhite1
force-pushed
the
jw-new-targets
branch
from
449a8b3
to
4248d2b
Compare
This comment has been minimized.
This comment has been minimized.
MitchLillie
requested changes
Mar 25, 2024
MitchLillie
reviewed
Mar 25, 2024
JoshuaWhite1
force-pushed
the
jw-new-targets
branch
from
9c2ca2b
to
947b443
Compare
MitchLillie
approved these changes
Mar 26, 2024
|
Hi! I have tried to deploy a variant admin extension, but despite updating the package, Shopify CLI still returns this error: Error while updating drafts: Invalid extension point(s) configured: admin.variant-details.action.render Is this target already supposed to work? |
|
Hi @bakura10 - Apologies, our docs were incorrect. The correct target name is |
|
Thanks, I can confirm this works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/Shopify/app-ui/issues/835
https://shopify-dev.ui-extensions-026v.josh-white.us.spin.dev/docs/api/admin-extensions/unstable/api/extension-targets
Adding type definitions for the new extension targets being added.
Targets being added:
Checklist