Unstable merge admin #703
Merged
Unstable merge admin #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vividviolet
force-pushed
the
unstable-merge-admin
branch
4 times, most recently
from
aae4653
to
3983acd
Compare
vividviolet
force-pushed
the
unstable-merge-admin
branch
from
3983acd
to
100cfed
Compare
lemonmade
approved these changes
Feb 3, 2023
| @@ -0,0 +1 @@ | |||
| export {useApi} from './api'; | |||
There was a problem hiding this comment.
Missing the re-export of useExtensionApi()?
| import {mount} from './mount'; | ||
|
|
||
| describe('useApi', () => { | ||
| it('returns api', async () => { |
There was a problem hiding this comment.
Nits: it would be nice if test names read as sentences
...xtensions/src/surfaces/checkout/components/BlockLayout/examples/basic-blockLayout.example.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Move Admin components to the shared packages. This has to be merged to and a new unstable release needs to go out before the Web PR can make use of it.
🎩
@shopify/ui-extensions-reactpackage with the new worker in Web: https://ui-extensions.web.e2e.trish-ta.us.spin.dev/?scriptUrl=https://e94f-142-188-16-206.ngrok.io/extensions/dev-a7bf7e92-8d8e-45dc-aa25-31c28142162f/assets/main.js#/unified@shopify/ui-extensionswith the new worker in Web: https://ui-extensions.web.e2e.trish-ta.us.spin.dev/?scriptUrl=https://e94f-142-188-16-206.ngrok.io/extensions/dev-6ac787b6-51c8-4e38-b359-3b1ce4710734/assets/main.js#/unifiedChecklist