Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix options initialization #270

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Fix options initialization #270

merged 2 commits into from
Jul 8, 2021

Conversation

vsumner
Copy link
Contributor

@vsumner vsumner commented Jul 8, 2021 •
edited
Loading

Description

This PR fixes the options initialization for the postcss-plugin.

Type of change

  • @shopify/postcss-plugin Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

dahukish
dahukish approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@dahukish dahukish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vsumner vsumner merged commit 4c61eff into main Jul 8, 2021
@vsumner vsumner deleted the fix-options-postcss-plugin branch July 8, 2021 14:37
@shopify-shipit shopify-shipit bot temporarily deployed to production July 8, 2021 15:13 Inactive
@shopify-shipit shopify-shipit bot deployed to loose-assumptions July 14, 2021 19:32 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahukish dahukish dahukish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsumner @dahukish