Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-plugin] Fix conflicting dependency on eslint #325

Merged
merged 1 commit into from
Mar 7, 2022
Merged

[eslint-plugin] Fix conflicting dependency on eslint #325

merged 1 commit into from
Mar 7, 2022

Conversation

xty
Copy link
Contributor

@xty xty commented Mar 7, 2022

Description

This PR addresses the following warnings raised when installing @shopify/eslint-plugin:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: eslint-plugin-promise@5.2.0
npm WARN Found: eslint@8.10.0
npm WARN node_modules/eslint
npm WARN   peer eslint@"^8.3.0" from @shopify/eslint-plugin@41.1.0
npm WARN   node_modules/@shopify/eslint-plugin
npm WARN     dev @shopify/eslint-plugin@"*" from the root project
npm WARN   20 more (@babel/eslint-parser, @babel/eslint-plugin, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer eslint@"^7.0.0" from eslint-plugin-promise@5.2.0
npm WARN node_modules/eslint-plugin-promise
npm WARN   eslint-plugin-promise@"^5.1.1" from @shopify/eslint-plugin@41.1.0
npm WARN   node_modules/@shopify/eslint-plugin
npm WARN
npm WARN Conflicting peer dependency: eslint@7.32.0
npm WARN node_modules/eslint
npm WARN   peer eslint@"^7.0.0" from eslint-plugin-promise@5.2.0
npm WARN   node_modules/eslint-plugin-promise
npm WARN     eslint-plugin-promise@"^5.1.1" from @shopify/eslint-plugin@41.1.0
npm WARN     node_modules/@shopify/eslint-plugin

Apparently, the ERESOLVE error is caused by eslint-plugin-promise@^5.1.1 requiring eslint@^7.0.0 as a peer dependency, and is fixed by bumping eslint-plugin-promise to 6.0.0 (which added ESlint v8 support but had not been released at the time of #305).

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish a new version for these changes)

@ghost ghost added the cla-needed label Mar 7, 2022
@xty
Copy link
Contributor Author

xty commented Mar 7, 2022

For users of @shopify/eslint-plugin, consider including the following in your package.json as a temporary workaround before this fix gets merged and published:

"overrides": {
	"@shopify/eslint-plugin": {
		"eslint-plugin-promise": "^6.0.0"
	}
} 

@xty
Copy link
Contributor Author

xty commented Mar 7, 2022

CLA signed. @BPScott, please take a look .

@ghost ghost removed the cla-needed label Mar 7, 2022
@BPScott
Copy link
Member

BPScott commented Mar 7, 2022

Thanks for spotting this! I'll try to get this released later today

@BPScott BPScott merged commit 5e7a533 into Shopify:main Mar 7, 2022
@BPScott
Copy link
Member

BPScott commented Mar 7, 2022

And published as v41.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants