Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefer-class-properties to ignore constructor overload declarations #408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matwilko
Copy link

Description

When used in a Typescript codebase, where constructor overloads/multiple signatures are definable, prefer-class-properties will throw an exception, as it currently assumes that there will only be one or zero constructor declarations in a class (which is true for JS, but not for TS).

So the following results in an exception when executing ESLint

class A {

    constructor();
    constructor(a: number = 0) {
        // ...
    }
}

because getConstructor() will find the empty constructor overload/signature first, and then subsequently fail when trying to access the body, which is null.

I've updated getConstructor() to ignore constructors with no body, so that the "real" constructor is found and analysed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant