Allow building numbers on address2 field for Austrian addresses #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochlefebvre
force-pushed
the
allow-building-number-on-address2-austria
branch
from
62bfa2d
to
1c865f8
Compare
cejaekl
approved these changes
Nov 10, 2023
devanandersen
approved these changes
Nov 10, 2023
|
I will resolve the CHANGELOG conflicts and merge this PR. |
rochlefebvre
force-pushed
the
allow-building-number-on-address2-austria
branch
from
1c865f8
to
1c91444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
After sampling 500 Austrian addresses at checkout, I counted 40 cases where the street name is on address1 and the building number (or building + unit) is on address2. Most of these addresses were otherwise valid.
I think we should recognize this addressing pattern as valid for Austria, and set
building_number_may_be_in_address2totruein the region definition.Checklist