Fix Beautify Anki in latest Anki version (2.1.49) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- self.typeCorrect was producing an infinite recursion - self._nextDueMsg() and self.next_learn_msg() have been deprecated after the TS + Rust rewrite (ankitects/anki@e568525) - Apparent now webview.css and deckbrowser.css are in the css/ folder
Based on datphan310 proposal to fix reviewer.py ShoroukAziz#58 I tested it locally and it works
|
Thanks a lot @fylux For your contribution. That seems to fix it for now. |
|
Thank you very much for the review! Please don't forget to generate a new github release including this patch. |
|
Done already. Thanks Again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried fix the add-on by simply spotting what part of the code was crashing and fixing it accordingly. I could trigger 3 different crashes and they were fixed in the following ways:
Overall, these are very hacky fixes because in ankitects/anki@e568525 most of the logic that this add-on uses was rewritten so to fix the add-on further a complete rewrite would be required. It might be that there are more crashes which this fix does not cover since I was the only tester.
Tested locally on Windows 10, Anki 2.1.49.
PS: Thanks to @datphan310 for the reviewer.py fix. Before I was just naively commenting the code.