Do not source when the plugin has been sourced #35

lambdalisue · 2016-03-11T09:39:45Z

's:source_plugin' possibly called twice or more when the plugin is depended from several plugins.
This commit simply skip if the plugin is already sourced, to prevent unnecessary function call and
&runtimepath duplication.

's:source_plugin' possibly called twice or more when the plugin is depended from several plugins. This commit simply skip if the plugin is already sourced, to prevent unnecessary function call and &runtimepath duplication.

lambdalisue · 2016-03-11T09:41:19Z

autoload/dein/autoload.vim

@@ -167,6 +167,9 @@ function! dein#autoload#_dummy_complete(arglead, cmdline, cursorpos) abort "{{{
 endfunction"}}}

 function! s:source_plugin(rtps, index, plugin) abort "{{{
+  if a:plugin.sourced


I was not really sure that I should use get(a:plugin, 'sourced') or not.
While dein.vim care about the startup speed, I just use a:plugin.source but if a:plugin could be an empty dictionary, it should be get(a:plugin, 'sourced') and I'll fix it then ;-)

lambdalisue · 2016-03-11T09:42:47Z

Before this patch

EchoRuntimePath:
/home/alisue/.config/nvim
/etc/xdg/xdg-gnome/nvim
/etc/xdg/nvim
/home/alisue/.local/share/nvim/site
/usr/share/gnome/nvim/site
/usr/local/share/nvim/site
/home/alisue/.vim/bundle/repos/github.com/thinca/vim-quickrun
/home/alisue/.vim/bundle/repos/github.com/haya14busa/incsearch.vim
/home/alisue/.vim/bundle/repos/github.com/tyru/capture.vim
/home/alisue/.vim/bundle/local/vim-gita
/home/alisue/.vim/bundle/repos/github.com/Shougo/vimfiler.vim
/home/alisue/.vim/bundle/repos/github.com/cohama/agit.vim
/home/alisue/.vim/bundle/repos/github.com/lambdalisue/vim-gista-unite
/home/alisue/.vim/bundle/repos/github.com/lambdalisue/vim-gista
/home/alisue/.vim/bundle/repos/github.com/Shougo/neomru.vim
/home/alisue/.vim/bundle/repos/github.com/thinca/vim-qfreplace
/home/alisue/.vim/bundle/repos/github.com/rafi/vim-unite-issue
/home/alisue/.vim/bundle/repos/github.com/tyru/open-browser.vim
/home/alisue/.vim/bundle/repos/github.com/mattn/webapi-vim
/home/alisue/.vim/bundle/repos/github.com/MattesGroeger/vim-bookmarks
/home/alisue/.vim/bundle/repos/github.com/cohama/agit.vim
/home/alisue/.vim/bundle/repos/github.com/lambdalisue/vim-gista-unite
/home/alisue/.vim/bundle/repos/github.com/lambdalisue/vim-gista
/home/alisue/.vim/bundle/repos/github.com/Shougo/neomru.vim
/home/alisue/.vim/bundle/repos/github.com/thinca/vim-qfreplace
/home/alisue/.vim/bundle/repos/github.com/rafi/vim-unite-issue
/home/alisue/.vim/bundle/repos/github.com/tyru/open-browser.vim
/home/alisue/.vim/bundle/repos/github.com/mattn/webapi-vim
/home/alisue/.vim/bundle/repos/github.com/Shougo/unite.vim
/home/alisue/.vim/bundle/repos/github.com/Shougo/neosnippet.vim
/home/alisue/.vim/bundle/repos/github.com/Shougo/context_filetype.vim
/home/alisue/.vim/bundle/repos/github.com/Shougo/neosnippet-snippets
/home/alisue/.vim/bundle/repos/github.com/Shougo/unite.vim
/home/alisue/.vim/bundle/.dein
/usr/share/nvim/site
/usr/share/nvim/runtime
/usr/share/nvim/site/after
/usr/local/share/nvim/site/after
/usr/share/gnome/nvim/site/after
/home/alisue/.local/share/nvim/site/after
/etc/xdg/nvim/after
/etc/xdg/xdg-gnome/nvim/after
/home/alisue/.config/nvim/after
/home/alisue/.vim
/home/alisue/.vim/bundle/repos/dein.vim
/home/alisue/.vim/bundle/.dein/after

After this patch

/home/alisue/.config/nvim
/etc/xdg/xdg-gnome/nvim
/etc/xdg/nvim
/home/alisue/.local/share/nvim/site
/usr/share/gnome/nvim/site
/usr/local/share/nvim/site
/home/alisue/.vim/bundle/repos/github.com/thinca/vim-quickrun
/home/alisue/.vim/bundle/repos/github.com/haya14busa/incsearch.vim
/home/alisue/.vim/bundle/local/vim-gita
/home/alisue/.vim/bundle/repos/github.com/Shougo/vimfiler.vim
/home/alisue/.vim/bundle/repos/github.com/cohama/agit.vim
/home/alisue/.vim/bundle/repos/github.com/lambdalisue/vim-gista-unite
/home/alisue/.vim/bundle/repos/github.com/lambdalisue/vim-gista
/home/alisue/.vim/bundle/repos/github.com/Shougo/neomru.vim
/home/alisue/.vim/bundle/repos/github.com/thinca/vim-qfreplace
/home/alisue/.vim/bundle/repos/github.com/rafi/vim-unite-issue
/home/alisue/.vim/bundle/repos/github.com/tyru/open-browser.vim
/home/alisue/.vim/bundle/repos/github.com/MattesGroeger/vim-bookmarks
/home/alisue/.vim/bundle/repos/github.com/Shougo/neosnippet.vim
/home/alisue/.vim/bundle/repos/github.com/Shougo/unite.vim
/home/alisue/.vim/bundle/repos/github.com/tyru/capture.vim
/home/alisue/.vim/bundle/.dein
/usr/share/nvim/site
/usr/share/nvim/runtime
/usr/share/nvim/site/after
/usr/local/share/nvim/site/after
/usr/share/gnome/nvim/site/after
/home/alisue/.local/share/nvim/site/after
/etc/xdg/nvim/after
/etc/xdg/xdg-gnome/nvim/after
/home/alisue/.config/nvim/after
/home/alisue/.vim
/home/alisue/Code/github.com/lambdalisue/dein.vim
/home/alisue/.vim/bundle/.dein/after

lambdalisue · 2016-03-11T10:00:46Z

It seems this change cause the following exception on startup. I'll fix and re-PR

Error detected while processing function <SNR>3_configure[13]..dein#local[1]..dein#parse#_local[24]..dein#add[1]..dein#parse#_add[1]..dein#parse#_dict:
line   69:
E909: Cannot index a special variable
E15: Invalid expression: plugin.rtp[0:] == '~'

lambdalisue · 2016-03-11T10:04:47Z

No. It seems that exception is not because of this PR (the exception could be shown even in 64397f6). It because of the following line in my plugin.toml

[[plugins]]
repo = 'Shougo/dein.vim'
rtp  = ''

This is completely different issue so I re-PR.

symbolix · 2016-03-11T11:02:11Z

@lambdalisue Hi, is this plugin.toml part of dein.vim or is it your custom setup? I am curious to see how the TOML plugin config is implemented. Thanks.

Shougo · 2016-03-11T11:11:58Z

@lambdalisue Hi, is this plugin.toml part of dein.vim or is it your custom setup? I am curious to see how the TOML plugin config is implemented. Thanks.

dein.vim can parse the TOML config.

Do not source when the plugin has been sourced

lambdalisue · 2016-03-11T11:13:04Z

Thanks ;-)

Shougo · 2016-03-11T11:13:06Z

OK, thanks.

lambdalisue · 2016-03-11T11:14:29Z

Is rtp = '' bug or did you drop this feature? @Shougo (Or my configuration problem)

Shougo · 2016-03-11T11:15:47Z

@lambdalisue It seems Vim's bug.
Please create new issue. I will check it.

lambdalisue · 2016-03-11T11:16:05Z

Ok. I'll do

lambdalisue · 2016-03-11T11:22:07Z

Ok. I couldn't reproduce that anymore. Maybe my configuration was wrong during development. I'm sorry for bothering you.

Shougo · 2016-03-11T11:24:32Z

Oh, ... Hm

symbolix · 2016-03-11T11:31:46Z

@lambdalisue @Shougo Yeah, I know the TOML parser is implemented both in neobundle and dein. However, could you please point me to an example TOML plugin config file and possibly a simple dein.vim implementation. Thank you very much. I am already migrating to dein.vim from Neobundle.

Shougo · 2016-03-11T11:40:40Z

This is my TOML config.

https://github.com/Shougo/shougo-s-github/blob/master/vim/rc/dein.toml

symbolix · 2016-03-11T11:45:47Z

Amazing! Thank you very much!

Do not source when the plugin has been sourced

7cfa7e1

's:source_plugin' possibly called twice or more when the plugin is depended from several plugins. This commit simply skip if the plugin is already sourced, to prevent unnecessary function call and &runtimepath duplication.

lambdalisue reviewed Mar 11, 2016
View reviewed changes

lambdalisue closed this Mar 11, 2016

lambdalisue reopened this Mar 11, 2016

Shougo added a commit that referenced this pull request Mar 11, 2016

Merge pull request #35 from lambdalisue/fix/runtimepath_duplication

ad363a4

Do not source when the plugin has been sourced

Shougo merged commit ad363a4 into Shougo:master Mar 11, 2016

lambdalisue deleted the fix/runtimepath_duplication branch March 11, 2016 11:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not source when the plugin has been sourced #35

Do not source when the plugin has been sourced #35

lambdalisue commented Mar 11, 2016

lambdalisue Mar 11, 2016

lambdalisue commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

symbolix commented Mar 11, 2016

Shougo commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

Shougo commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

Shougo commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

Shougo commented Mar 11, 2016

symbolix commented Mar 11, 2016

Shougo commented Mar 11, 2016

symbolix commented Mar 11, 2016

Do not source when the plugin has been sourced #35

Do not source when the plugin has been sourced #35

Conversation

lambdalisue commented Mar 11, 2016

lambdalisue Mar 11, 2016

Choose a reason for hiding this comment

lambdalisue commented Mar 11, 2016

Before this patch

After this patch

lambdalisue commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

symbolix commented Mar 11, 2016

Shougo commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

Shougo commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

Shougo commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

lambdalisue commented Mar 11, 2016

Shougo commented Mar 11, 2016

symbolix commented Mar 11, 2016

Shougo commented Mar 11, 2016

symbolix commented Mar 11, 2016