You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently denite.vim support Vim 8 by extending vim module directly but
vim is shared to all plugins so once your approach got famous, there would be tons of variation of vim.call() implementations and each other will be conflict
vim.vars, vim.options or whatever returns bytes instead of str in Python 3 and it would cause Unicode encode/decode error
RFC
Recently I made vim-rplugin to solve all problems above.
So what do you think about relying on that plugin to support Vim 8? If you are OK with this idea, I will implement the feature sometime ;-)
Pros.
You can remove most of code for Vim 8 so the code become more simple
It wrap vim module rather than extend so that vim.call() always returns what you want.
It automatically decode bytes to str so you don't have to change codes for Neovim and Vim 8
Cons.
User who want to use denite.nvim in Vim 8 need to install lambdalisue/vim-rplugin as well.
Performance may decrease in Vim 8 while vim-rplugin use Proxy strategy
The text was updated successfully, but these errors were encountered:
In case while I forgot to mention, vim-rplugin is only required for people who want to use the plugin in vim8 and neovim user never need that.
That why I decide to rely on that plugin for further my products while I decide to use rplugin strategy for main and vim8 support is now optional feature for me.
In case if you mis-understood and thought the vim-rplugin dependency exist also for neovim users.
Problems summary
Currently denite.vim support Vim 8 by extending
vim
module directly butvim
is shared to all plugins so once your approach got famous, there would be tons of variation ofvim.call()
implementations and each other will be conflictvim.vars
,vim.options
or whatever returnsbytes
instead ofstr
in Python 3 and it would cause Unicode encode/decode errorRFC
Recently I made vim-rplugin to solve all problems above.
So what do you think about relying on that plugin to support Vim 8? If you are OK with this idea, I will implement the feature sometime ;-)
Pros.
vim
module rather than extend so thatvim.call()
always returns what you want.bytes
tostr
so you don't have to change codes for Neovim and Vim 8Cons.
The text was updated successfully, but these errors were encountered: