Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Error: Module did not self-register" with Node v12 worker threads #212

Closed
nanpx opened this issue Jan 13, 2020 · 0 comments · Fixed by #213
Closed

"Error: Module did not self-register" with Node v12 worker threads #212

nanpx opened this issue Jan 13, 2020 · 0 comments · Fixed by #213

Comments

@nanpx
Copy link
Contributor

nanpx commented Jan 13, 2020

I'm unable to load dbus when using worker threads. Instead I get "Error: Module did not self-register."

I've created a dbus worker threads gist to demo the error. I have been able to compile, pass all tests, and verify that changing to NAN_MODULE_WORKER_ENABLED does resolve the error message. However, I believe the long-term solution is to become context aware compatible if worker threads are to be supported.
nanpx added a commit to nanpx/node-dbus that referenced this issue Jan 13, 2020
@nanpx
Support worker threads
72be96a 
Add NAN_MODULE_WORKER_ENABLED macro as a replacement for NAN_MODULE.
Closes Shouqun#212
@nanpx nanpx mentioned this issue Jan 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support worker threads nanpx/node-dbus
1 participant
@nanpx