Add callback function support to callMethod in/out defs. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld be replied to DBus insteadof type 'v'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenario, addProperty does not send correct data to
DBus. For example, in bluez api, ManufacturerData's dict key must be uint16), but JS does not support number-type key. Sinceoutvalue was forced to set toUtils.Define('Auto', 'value')in when implementingorg.freedesktop.DBus.Properties, the returned value'sprop_keywas mis-transformed tostring.This PR introduced function support when defining method, so value type could be dynamic returned according args.