feat(customer-profile-board): init commit #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 9, 2016 18:40
… customer profile board
…mer profile board
…iguration customer attribute display item
Current coverage is 31.79% (diff: 47.11%)@@ dev #119 diff @@
==========================================
Files 49 58 +9
Lines 2430 2765 +335
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 765 879 +114
- Misses 1665 1886 +221
Partials 0 0
|
|
@arzyu 当前组件目前还不能发布，api 定义方面还有些问题。 |
|
|
||
| export default angular | ||
| .module('ccms.components.customerProfileBoard', [bindHTML]) | ||
| .service('CustomerProfileBoardService', CustomerProfileBoardService) |
There was a problem hiding this comment.
service 及 组件 命名遵循 cc 前缀法
这里的服务应该改为 $ccCustomerProfileBoard 或者简单点 $ccCPB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init commit for other team test.