Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal):modal close时需提前移除listener,而不是在removeClass callback中再移除 #90

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

kuitos
Copy link
Contributor

@kuitos kuitos commented Jul 22, 2016

removeClass callback中再移除 hashchange listener 会出现 remove callback 比 hashchange 晚触发的异步问题

@arzyu arzyu added the reviewed label Jul 27, 2016
@arzyu arzyu merged commit 0e2851e into dev Jul 27, 2016
@arzyu arzyu deleted the fix/modal-listener-remove branch July 27, 2016 06:40
@arzyu arzyu added reviewed and removed reviewed labels Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants