-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver for the sensirion sht85 sensor #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this thing is getting quite complicated for a temperature sensor 🙈
would like to hear what @DavidLP thinks about some of my comments..
Pretty nice first commit into basil! |
I do not know the Sensirion box etc. so it is tough for me to judge this. From what I read, it works as the following:
I mean that is (as I can quickly judge) a very clean and generic implementation to support hardware we have and to support hardware we don't have ;-) If we are only going to use the bridge with the temperature sensors, one could maybe just make one driver and skip the extra TL. |
94cc814
to
e603e1a
Compare
I recommend to configure your editor in a way that it takes care of the code style. Good editors (pydev, VStudio Code, ...) can do that. When you clean up the formatting issues https://travis-ci.org/github/SiLab-Bonn/basil/jobs/741928925#L5989 it is fine to be merged. You can check for code flaws by typing:
|
Also, you see that the CI failed due to code flaws |
Adds a driver for the sensirion sht85 sensor and a sensirion sensor bridge. It uses official drivers of sensirion to communicate with the sensor bridge.