fixed waypoint issue and added phpunit test for waypoint loading #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sibyx
requested changes
Mar 8, 2017
|
sure
sorry about that should have thought of that
Rob
…Sent from my iPhone
On Mar 8, 2017, at 08:33, Jakub Dubec ***@***.***> wrote:
@Sibyx requested changes on this pull request.
Hi, thanks for the pull request. Everything is fine just one thing. Can you please remove:
.DS_Store files
composer.lock (Composer lock file is not needed in library projects)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sibyx
approved these changes
Mar 8, 2017
|
Looks good, merging ;) Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix was a simple one-liner