Emby Test and Post

[BKSteve]

Emby test not working and update library post to non deprecated webhook

Summary by CodeRabbit

• Bug Fixes
  • Updated the notification system to use POST requests for improved reliability and security.
  • Modified the library update endpoint for better compatibility.

[coderabbitai]

Walkthrough

The recent update introduces a significant change in how notifications are handled with Emby. Specifically, it transitions the method of notifying Emby from a GET to a POST request, ensuring a more secure and standard approach to sending data. Additionally, the update includes a modification to the Emby library update endpoint, optimizing the communication process between the software and the Emby server.

Changes

File Path	Change Summary
.../notifiers/emby.py	Switched from GET to POST in _notify_emby; Updated endpoint URL in update_library method.

🐰✨
In the code's burrow, deep and wide,
Changes stir, from inside.
From GET to POST, we hop with pride,
With Emby's call, our paths collide.
🌟 A new journey, side by side. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 1676415 and e530226.

Files selected for processing (1)

• sickchill/oldbeard/notifiers/emby.py (2 hunks)

Additional comments: 1

sickchill/oldbeard/notifiers/emby.py (1)

• 63-63: Updating the endpoint URL in the update_library method from a deprecated one to "emby/Library/Media/Updated" is a necessary change to ensure compatibility with current Emby server requirements. This change correctly addresses the PR's objective of using a non-deprecated endpoint for library updates. It's crucial to verify that the new endpoint expects the same parameters, especially the TvdbId for a specific show, and that it processes these parameters in the expected manner. If the documentation or API specification for the Emby server provides any additional requirements for the request body or headers when using this endpoint, those should be incorporated to ensure the request is correctly formed and accepted by the Emby server.